On Tue, Apr 16, 2024 at 02:40:39PM +0000, "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx> wrote: > On Wed, 2024-04-10 at 15:07 -0700, isaku.yamahata@xxxxxxxxx wrote: > > From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx> > > > > The guest memory population logic will need to know what page size or level > > (4K, 2M, ...) is mapped. > > TDX needs this, but do the normal VM users need to have it fixed to 4k? Is it > actually good? I meant that the function, kvm_arch_vcpu_map_memory(), in [PATCH v2 06/10] KVM: x86: Implement kvm_arch_vcpu_map_memory() needs level. No logic in this patch series enforces to fixed 4K. gmem_max_level() hook will determine it. https://lore.kernel.org/all/20240404185034.3184582-12-pbonzini@xxxxxxxxxx/ I'll update the commit message to reflect it. -- Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
