On Thu Apr 11, 2024 at 5:03 PM AEST, Thomas Huth wrote: > On 06/04/2024 14.38, Nicholas Piggin wrote: > > This adds a basic shellcheck sytle file, some directives to help > > s/sytle/style/ > > > find scripts, and a make shellcheck target. > > > > When changes settle down this could be made part of the standard > > build / CI flow. > > > > Suggested-by: Andrew Jones <andrew.jones@xxxxxxxxx> > > Reviewed-by: Andrew Jones <andrew.jones@xxxxxxxxx> > > Signed-off-by: Nicholas Piggin <npiggin@xxxxxxxxx> > > --- > ... > > diff --git a/README.md b/README.md > > index 6e82dc225..03ff5994e 100644 > > --- a/README.md > > +++ b/README.md > > @@ -193,3 +193,6 @@ with `git config diff.orderFile scripts/git.difforder` enables it. > > > > We strive to follow the Linux kernels coding style so it's recommended > > to run the kernel's ./scripts/checkpatch.pl on new patches. > > + > > +Also run make shellcheck before submitting a patch which touches bash > > I'd maybe put "make shellcheck" in quotes to make the sentence more readable? Agreed. Thanks, Nick
