> From: Sean Christopherson <seanjc@xxxxxxxxxx> > Sent: Friday, April 12, 2024 10:28 PM > > On Fri, Apr 12, 2024, Kevin Tian wrote: > > > From: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx> > > > Sent: Saturday, April 6, 2024 6:31 AM > > > > > > +/* > > > + * Posted interrupt notification vector for all device MSIs delivered to > > > + * the host kernel. > > > + */ > > > +#define POSTED_MSI_NOTIFICATION_VECTOR 0xeb > > > #define NR_VECTORS 256 > > > > > > > Every interrupt is kind of a notification. > > FWIW, I find value in having "notification" in the name to differentiate > between > the IRQ that is notifying the CPU that there's a posted IRQ to be processed, > and > the posted IRQ itself. IMHO one who knows posted msi doesn't need the extra 'notification' in the name to differentiate. one who doesn't know what posted msi is anyway needs to look at the surrounding code including the above comment. having 'notification' in the name alone doesn't really help. but I'd not hold strong on this... 😊
