Re: [kvm-unit-tests PATCH 2/2] s390x: Fix is_pv check in run script

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 4/6/24 14:24, Nicholas Piggin wrote:
Shellcheck reports "is_pv references arguments, but none are ever
passed." and suggests "use is_pv "$@" if function's $1 should mean
script's $1."

The is_pv test does not evaluate to true for .pv.bin file names, only
for _PV suffix test names. The arch_cmd_s390x() function appends
.pv.bin to the file name AND _PV to the test name, so this does not
affect runs, but it might prevent PV tests from being
run directly with the s390x-run command.

The only thing that changes with this patch is that we get the error message from s390x/run and not from QEMU which complains about the unpack facility (needed for PV) not being available (because TCG does not implement it).
And that's likely why we never ran into any problems.

Patch looks fine to me:
Reviewed-by: Janosch Frank <frankja@xxxxxxxxxxxxx>

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux