On Wed, Mar 27, 2024 at 05:27:52PM +0000, "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx> wrote: > On Wed, 2024-03-27 at 10:22 -0700, Isaku Yamahata wrote: > > On Mon, Mar 25, 2024 at 11:41:56PM +0000, > > "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx> wrote: > > > > > On Mon, 2024-02-26 at 00:25 -0800, isaku.yamahata@xxxxxxxxx wrote: > > > > From: Chao Gao <chao.gao@xxxxxxxxx> > > > > > > > > TODO: Drop this patch once the common patch is merged. > > > > > > What is this TODO talking about? > > > > https://lore.kernel.org/all/ZcUO5sFEAIH68JIA@xxxxxxxxxx/ > > > > This patch was shot down and need to fix it in guest side. TDVF. > > It needs a firmware fix? Is there any firmware that works (boot any TD) with this patch missing? Yes. Config-B (OvmfPkg/IntelTdx/IntelTdxX64.dsc) works for me without this patch. I'm looking into config-A(OvmfPkg/OvmfPkgX64.dsc) now. -- Isaku Yamahata <isaku.yamahata@xxxxxxxxx>