RE: [PATCH 4/4 v3] KVM: VMX: VMXON/VMXOFF usage changes.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Avi Kivity wrote:
> On 05/11/2010 12:38 PM, Xu, Dongxiao wrote:
>> 
>>> I'm not sure why this is needed.  vmx_cpuid_update() is called from
>>> a vcpu ioctl which should have called vcpu_load() before.
>>> 
>>> Apart from that, everything looks good for merging.
>>> 
>> Vcpu_load() and vcpu_put() is not called in that ioctl. I will add
>> that and send out another version of patchset.
>> 
> 
> That's a serious bug even before this patchset, since vmx_cpuid_update
> accesses the vmcs.  Please send the fix as a separate patch (which
> will be backported to -stable).

That's OK. 

Thanks
Dongxiao--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux