Re: [PATCH v2 0/2] Two enhancements to iommu_at[de]tach_device_pasid()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 2024/3/29 10:12, Duan, Zhenzhong wrote:

-----Original Message-----
From: Liu, Yi L <yi.l.liu@xxxxxxxxx>
Subject: [PATCH v2 0/2] Two enhancements to

There are minor mistakes in the iommu set_dev_pasid() and
paths. The set_dev_pasid() path updates the group->pasid_array first, and
then call into remove_dev_pasid() in error handling when there are devices
within the group that failed to set_dev_pasid.

Not related to this patch, just curious in which cases some of the devices
In same group failed to set_dev_pasid while others succeed?
There are multiple failure reasons. Given to the fact of some devices have already succeeded, the most typical error may be no memory. Not sure about
other reasons.

Yi Liu


The remove_dev_pasid()
callbacks of the underlying iommu drivers get the domain for pasid from the
group->pasid_array. So the remove_dev_pasid() callback may get a wrong
in the set_dev_pasid() path. [1] Even if the group is singleton, the existing
code logic would have unnecessary warnings in the error handling of the
set_dev_pasid() path. e.g. intel iommu driver.

The above issue can be fixed by improving the error handling in the
set_dev_pasid() path. Also, this reminds that it is not reliable for the
underlying iommu driver callback to get the domain from group-
So, the second patch of this series passes the domain to remove_dev_pasid


Change log:

- Make clear that the patch 1/2 of v1 does not fix the problem (Kevin)
- Swap the order of patch 1/2 and 2/2 of v1. In this new series, patch 1/2
   fixes the real issue, patch 2/2 is to avoid potential issue in the future.


	Yi Liu

Yi Liu (2):
  iommu: Undo pasid attachment only for the devices that have succeeded
  iommu: Pass domain to remove_dev_pasid() op

drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |  9 ++-----
drivers/iommu/intel/iommu.c                 | 11 +++-----
drivers/iommu/iommu.c                       | 28 ++++++++++++++-------
include/linux/iommu.h                       |  3 ++-
4 files changed, 26 insertions(+), 25 deletions(-)


Yi Liu

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux