Re: [PATCH v19 039/130] KVM: TDX: initialize VM with TDX specific parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Thu, 2024-03-28 at 09:36 +0800, Xiaoyao Li wrote:
> > > > Any reason to mask off non-configurable bits rather than return an error? this
> > > > is misleading to userspace because guest sees the values emulated by TDX module
> > > > instead of the values passed from userspace (i.e., the request from userspace
> > > > isn't done but there is no indication of that to userspace).
> > > 
> > > Ok, I'll eliminate them.  If user space passes wrong cpuids, TDX module will
> > > return error. I'll leave the error check to the TDX module.
> > 
> > I was just looking at this. Agreed. It breaks the selftests though.
> If all you prefer to go this direction, then please update the error 
> handling of this specific SEAMCALL.

What do you mean by SEAMCALL, TDH_MNG_INIT? Can you be more specific?

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux