Re: [PATCH 2/2] iommu: Undo pasid attachment only for the devices that have succeeded

[Yi Liu <yi.l.liu@xxxxxxxxx>]

On 2024/3/28 11:15, Tian, Kevin wrote:
> > From: Liu, Yi L <yi.l.liu@xxxxxxxxx>
> > Sent: Wednesday, March 27, 2024 8:55 PM
> > +
> > +err_revert:
> > +	last_gdev = device;
> > +	for_each_group_device(group, device) {
> > +		if (device == last_gdev)
> > +			break;
> > +		dev_iommu_ops(device->dev)->remove_dev_pasid(device-
> > > dev,
> > +							     pasid, domain);
> > +	}
>
> break the long line into:
> 	ops = dev_iommu_ops(device->dev);
> 	ops->remove_dev_pasid();

got it.

> otherwise it looks good to me:
>
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

--
Regards,
Yi Liu