On 05/10/2010 02:46 PM, Takuya Yoshikawa wrote:
(2010/05/06 22:38), Arnd Bergmann wrote:
On Wednesday 05 May 2010, Takuya Yoshikawa wrote:
Date:
Yesterday 04:59:24
That's why the bitmaps are defined as little endian u64 aligned,
even on
big endian 32-bit systems. Little endian bitmaps are wordsize
agnostic,
and u64 alignment ensures we can use long-sized bitops on mixed size
systems.
Ok, I see.
There was a suggestion to propose set_le_bit_user() kind of macros.
But what I thought was these have a constraint you two explained and
seemed to be
a little bit specific to some area, like KVM.
So I decided to propose just the offset calculation macro.
I'm not sure I understand how this macro is going to be used though.
If you are just using this in kernel space, that's fine, please go for
it.
Yes, I'm just using in kernel space: qemu has its own endian related
helpers.
So if you allow us to place this macro in asm-generic/bitops/* it will
help us.
Avi, what do you think? Do you want to place it in kvm.h ?
I really prefer anything that is generic to be outside kvm, even if kvm
is the only user.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
