On Tue, 2024-03-19 at 17:09 -0700, Isaku Yamahata wrote: > > The helper abstracts setting the arguments into the proper > > registers > > fields passed in, but doesn't abstract pulling the result out from > > the > > register fields. Then the caller has to manually extract them in > > this > > verbose way. Why not have the helper do both? > > Yes. Let me update those arguments. What were you thinking exactly, like? tdh_mem_sept_add(kvm_tdx, gpa, tdx_level, hpa, &entry, &level_state); And for the other helpers?