On 05/06/2010 10:10 PM, Marcelo Tosatti wrote:
On Tue, May 04, 2010 at 01:03:50PM +0300, Avi Kivity wrote:
On svm, kvm_read_pdptr() may require reading guest memory, which can sleep.
Push the spinlock into mmu_alloc_roots(), and only take it after we've read
the pdptr.
Marcelo, dropping and re-acquiring the lock before mmu_sync_roots(), is fine,
yes?
Yes, but you should call kvm_mmu_free_some_pages after reacquiring the
spin_lock, to guarantee kvm_mmu_alloc_page won't fail.
We never fail due to lack of free pages (but I agree it's cleaner).
The patch is already in, I'll send an incremental.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
