On Thu, Mar 14, 2024 at 09:52:58PM +0000, "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx> wrote: > On Thu, 2024-03-14 at 11:10 -0700, Isaku Yamahata wrote: > > > I think the point of putting these in a union is that they only > > > apply > > > to shadow paging and so can't be used with TDX. I think you are > > > putting > > > more than the sizeof(void *) in there as there are multiple in the > > > same > > > category. > > > > I'm not sure if I'm following you. > > On x86_64, sizeof(unsigned int) = 4, sizeof(atomic_t) = 4, > > sizeof(void *) = 8. > > I moved write_flooding_count to have 8 bytes. > > Ah, I see. Yes you are write about it summing to 8. Ok, what do you > think about putting a comment that these will always be unused with > TDX? Ok, will add a comment. Also add some to the commit message. -- Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
