On Thu, Mar 14, 2024 at 03:30:43PM +0800, Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx> wrote: > > +#define TDX_TD_ATTRIBUTE_DEBUG BIT_ULL(0) > > +#define TDX_TD_ATTR_SEPT_VE_DISABLE BIT_ULL(28) > It's better to align the style of the naming. > > Either use TDX_TD_ATTR_* or TDX_TD_ATTRIBUTE_*? Good point. I'll adopt TDX_TD_ATTR_* because TDX_TD_ATTR_SEPT_VE_DISABLE is already long. -- Isaku Yamahata <isaku.yamahata@xxxxxxxxx>