Oliver Upton <oliver.upton@xxxxxxxxx> writes:
- asm volatile("wfi\n" - "msr daifclr, #2\n" - /* handle IRQ */ - "msr daifset, #2\n" - : : : "memory"); + gic_wfi(); + local_irq_enable(); + isb(); + /* handle IRQ */ + local_irq_disable();
Sorry, this *still* annoys me. Please move the comment above the ISB, you're documenting a behavior that is implied by the instruction, not anything else.
Fixing this too. I changed this in the third patch but forgot there was also an instance in the second.
