On Fri, 8 Mar 2024 07:16:02 +0000
"Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:
> > From: Alex Williamson <alex.williamson@xxxxxxxxxx>
> > Sent: Thursday, March 7, 2024 5:15 AM
> >
> > @@ -321,8 +321,13 @@ void vfio_platform_irq_cleanup(struct
> > vfio_platform_device *vdev)
> > {
> > int i;
> >
> > - for (i = 0; i < vdev->num_irqs; i++)
> > + for (i = 0; i < vdev->num_irqs; i++) {
> > + int hwirq = vdev->get_irq(vdev, i);
>
> hwirq is unused.
Yep, poor split with the next patch. I'll update the next patch to use
vdev->irqs[i].hwirq here and in the unwind on init to avoid this. Thanks,
Alex
> > +
> > + vfio_virqfd_disable(&vdev->irqs[i].mask);
> > + vfio_virqfd_disable(&vdev->irqs[i].unmask);
> > vfio_set_trigger(vdev, i, -1, NULL);
> > + }
> >
> > vdev->num_irqs = 0;
> > kfree(vdev->irqs);
> > --
> > 2.43.2
>
