On 2/26/24 16:25, isaku.yamahata@xxxxxxxxx wrote: > + /* > + * This is racy with updating memory attributes with mmu_seq. If we > + * hit a race, it would result in retrying page fault. > + */ > + if (vcpu->kvm->arch.vm_type == KVM_X86_SW_PROTECTED_VM && There are more than two times of similar check in this patchset. Maybe it's better to add a helper function to tell whether the type is KVM_X86_SW_PROTECTED_VM? Regards Yin, Fengwei > + kvm_mem_is_private(vcpu->kvm, gpa_to_gfn(cr2_or_gpa))) > + error_code |= PFERR_GUEST_ENC_MASK; > +