On Wed, Apr 28, 2010 at 8:55 AM, Michael Goldish <mgoldish@xxxxxxxxxx> wrote:
> On 04/26/2010 01:04 PM, Jason Wang wrote:
>> If the screendump and scrialdump threads are created after the
>> process(), we may lose the progress tracking of guest shutting
>> down. So this patch creates them before calling process() in preprocess.
>>
>> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
>> ---
>> client/tests/kvm/kvm_preprocessing.py | 5 ++---
>> 1 files changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/client/tests/kvm/kvm_preprocessing.py b/client/tests/kvm/kvm_preprocessing.py
>> index 50d0e35..73e835a 100644
>> --- a/client/tests/kvm/kvm_preprocessing.py
>> +++ b/client/tests/kvm/kvm_preprocessing.py
>> @@ -257,9 +257,6 @@ def preprocess(test, params, env):
>> int(params.get("pre_command_timeout", "600")),
>> params.get("pre_command_noncritical") == "yes")
>>
>> - # Preprocess all VMs and images
>> - process(test, params, env, preprocess_image, preprocess_vm)
>> -
>> # Start the screendump thread
>> if params.get("take_regular_screendumps") == "yes":
>> logging.debug("Starting screendump thread")
>> @@ -278,6 +275,8 @@ def preprocess(test, params, env):
>> args=(test, params, env))
>> _serialdump_thread.start()
>>
>> + # Preprocess all VMs and images
>> + process(test, params, env, preprocess_image, preprocess_vm)
>>
>>
>> def postprocess(test, params, env):
>
> The initial shutdown procedure is carried out automatically by the
> preprocessor in order to prepare the VMs for the current test, and is
> not part of the test. During the procedure VMs from a previous test are
> shut down and/or restarted. I think it'll be confusing (or at least
> irrelevant) for the user to see a Fedora guest shutting down at the
> beginning of a Windows test. Also, it will be inconsistent with the
> pre_*.ppm screendumps which are taken after the new VMs are started.
Agreed. Besides, if we didn't specify kill_vm for that particular
test, it means that we are not terribly interested on what happens
with the VM if it has to be shutdown (worst case scenario is, the
postprocessor will quit the VM). Of course, it is allways scary to
loose information, but I can't think on why we'd need that info anyway
(correct me if I am wrong).
--
Lucas
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
