Re: [kvm-unit-tests PATCH 03/32] powerpc: Fix stack backtrace termination

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/03/2024 07.29, Nicholas Piggin wrote:
On Tue Feb 27, 2024 at 6:50 PM AEST, Thomas Huth wrote:
On 26/02/2024 11.11, Nicholas Piggin wrote:
...
   	/* save DTB pointer */
-	std	r3, 56(r1)
+	SAVE_GPR(3,r1)

Isn't SAVE_GPR rather meant for the interrupt frame, not for the normal C
calling convention frames?

Sorry for asking dumb questions ... I still have a hard time understanding
the changes here... :-/

Ah, that was me being lazy and using an interrupt frame for the new
frame.

Ah, ok. It's super-confusing (at least for me) to see an interrupt frame here out of no reason... could you please either add proper comments here explaining this, or even better switch to a normal stack frame, please?

 Thanks,
  Thomas





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux