On Tue, 27 Feb 2024 11:49:14 +0000, David Woodhouse wrote: > These apply to the kvm-x86/xen tree. > > First, deal with the awful brokenness of the KVM clock, and its systemic > drift especially when TSC scaling is used. This is a bit of a workaround > for Xen timers where it hurts *most*, but it's actually easier in this > case because there is a vCPU (and associated PV clock information) to > use for the scaling. A better fix for __get_kvmclock() is in the works, > but there's an enormous yak to shave there because there are so many > interrelated bugs in the TSC and timekeeping code. > > [...] Applied 1-5 to kvm-x86 xen. Please take a look and test the result (patches 1 and 4 in particular). I didn't _intend_ to make any functional changes outside of fixing up the unlock goof, but I'd greatly appreciate extra eyeballs, especially this close to the merge window. Oh, and can you look at v2[*] of Vitaly's fixes for xen_shinfo_test? I'd like to get that applied soonish (I see intermittent failures), but I'm nowhere near competent enough with clocks to give it a proper review. Thanks! [*] https://lore.kernel.org/all/20240206151950.31174-1-vkuznets@xxxxxxxxxx [1/8] KVM: x86/xen: improve accuracy of Xen timers https://github.com/kvm-x86/linux/commit/451a707813ae [2/8] KVM: x86/xen: inject vCPU upcall vector when local APIC is enabled https://github.com/kvm-x86/linux/commit/8e62bf2bfa46 [3/8] KVM: x86/xen: remove WARN_ON_ONCE() with false positives in evtchn delivery https://github.com/kvm-x86/linux/commit/66e3cf729b1e [4/8] KVM: pfncache: simplify locking and make more self-contained https://github.com/kvm-x86/linux/commit/6addfcf27139 [5/8] KVM: x86/xen: fix recursive deadlock in timer injection https://github.com/kvm-x86/linux/commit/7a36d680658b [6/8] KVM: x86/xen: split up kvm_xen_set_evtchn_fast() (not applied) [7/8] KVM: x86/xen: avoid blocking in hardirq context in kvm_xen_set_evtchn_fast() (not applied) [8/8] KVM: pfncache: clean up rwlock abuse (not applied) -- https://github.com/kvm-x86/linux/tree/next