On Wed, Feb 28, 2024 at 01:19:48PM -0800, Sean Christopherson wrote: > I'll squash the above and force push. Thanks, I'll give that a spin (likely tomorrow at this point). > And another question: is there any reason to not force -Werror for selftests? Enabling it by default can cause a bunch of fragility when people are running different compilers, there's things like all the different clang versions, and it's especially common to run into issues when you've got a shiny new compiler on a modern distro but need to go look at older kernels for some reason. You then get issues bisecting things since you get regions where the build was broken due to -Werror which may or may not be pointing at the runtime issue you were looking for (particularly likely to be hiding things if the build issue is in a different test).
Attachment:
signature.asc
Description: PGP signature