On Tue, Feb 27, 2024, Dongli Zhang wrote: > > > On 2/27/24 18:41, Sean Christopherson wrote: > > Define more #NPF error code flags that are relevant to SEV+ (mostly SNP) > > guests, as specified by the APM: > > > > * Bit 34 (ENC): Set to 1 if the guest’s effective C-bit was 1, 0 otherwise. > > * Bit 35 (SIZEM): Set to 1 if the fault was caused by a size mismatch between > > PVALIDATE or RMPADJUST and the RMP, 0 otherwise. > > * Bit 36 (VMPL): Set to 1 if the fault was caused by a VMPL permission > > check failure, 0 otherwise. > > * Bit 37 (SSS): Set to VMPL permission mask SSS (bit 4) value if VmplSSS is > > enabled. > > The above bits 34-37 do not match with the bits 31,34-36 in the patch. Doh, good catch. I copy+pasted this from the APM, but the RMP bit is defined slightly earlier in the APM, and I missed SSS. I'll fixup the changelog to talk about RMO, and I think I'll add SSS in v2; at the very least, having the #define will make it clear which bits are used. Thanks!
