> -----Original Message----- > From: Zhao Liu <zhao1.liu@xxxxxxxxxxxxxxx> > Sent: Tuesday, February 20, 2024 5:25 PM > To: Daniel P . Berrangé <berrange@xxxxxxxxxx>; Eduardo Habkost <eduardo@xxxxxxxxxxx>; Marcel Apfelbaum > <marcel.apfelbaum@xxxxxxxxx>; Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>; Yanan Wang <wangyanan55@xxxxxxxxxx>; > Michael S . Tsirkin <mst@xxxxxxxxxx>; Paolo Bonzini <pbonzini@xxxxxxxxxx>; Richard Henderson <richard.henderson@xxxxxxxxxx>; > Eric Blake <eblake@xxxxxxxxxx>; Markus Armbruster <armbru@xxxxxxxxxx>; Marcelo Tosatti <mtosatti@xxxxxxxxxx>; Alex Bennée > <alex.bennee@xxxxxxxxxx>; Peter Maydell <peter.maydell@xxxxxxxxxx>; Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>; > JeeHeng Sia <jeeheng.sia@xxxxxxxxxxxxxxxx> > Cc: qemu-devel@xxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; qemu-riscv@xxxxxxxxxx; qemu-arm@xxxxxxxxxx; Zhenyu Wang > <zhenyu.z.wang@xxxxxxxxx>; Dapeng Mi <dapeng1.mi@xxxxxxxxxxxxxxx>; Yongwei Ma <yongwei.ma@xxxxxxxxx>; Zhao Liu > <zhao1.liu@xxxxxxxxx> > Subject: [RFC 2/8] hw/core: Move CPU topology enumeration into arch-agnostic file > > From: Zhao Liu <zhao1.liu@xxxxxxxxx> > > Cache topology needs to be defined based on CPU topology levels. Thus, > move CPU topology enumeration into a common header. > > To match the general topology naming style, rename CPU_TOPO_LEVEL_SMT > and CPU_TOPO_LEVEL_PACKAGE to CPU_TOPO_LEVEL_THREAD and > CPU_TOPO_LEVEL_SOCKET. > > Also, enumerate additional topology levels for non-i386 arches, and add > helpers for topology enumeration and string conversion. > > Signed-off-by: Zhao Liu <zhao1.liu@xxxxxxxxx> > --- > MAINTAINERS | 2 ++ > hw/core/cpu-topology.c | 56 ++++++++++++++++++++++++++++++++++ > hw/core/meson.build | 1 + > include/hw/core/cpu-topology.h | 40 ++++++++++++++++++++++++ > include/hw/i386/topology.h | 18 +---------- > target/i386/cpu.c | 24 +++++++-------- > target/i386/cpu.h | 2 +- > tests/unit/meson.build | 3 +- > 8 files changed, 115 insertions(+), 31 deletions(-) > create mode 100644 hw/core/cpu-topology.c > create mode 100644 include/hw/core/cpu-topology.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7d61fb93194b..4b1cce938915 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1871,6 +1871,7 @@ R: Yanan Wang <wangyanan55@xxxxxxxxxx> > S: Supported > F: hw/core/cpu-common.c > F: hw/core/cpu-sysemu.c > +F: hw/core/cpu-topology.c > F: hw/core/machine-qmp-cmds.c > F: hw/core/machine.c > F: hw/core/machine-smp.c > @@ -1882,6 +1883,7 @@ F: qapi/machine-common.json > F: qapi/machine-target.json > F: include/hw/boards.h > F: include/hw/core/cpu.h > +F: include/hw/core/cpu-topology.h > F: include/hw/cpu/cluster.h > F: include/sysemu/numa.h > F: tests/unit/test-smp-parse.c > diff --git a/hw/core/cpu-topology.c b/hw/core/cpu-topology.c > new file mode 100644 > index 000000000000..ca1361d13c16 > --- /dev/null > +++ b/hw/core/cpu-topology.c > @@ -0,0 +1,56 @@ > +/* > + * QEMU CPU Topology Representation > + * > + * Copyright (c) 2024 Intel Corporation > + * Author: Zhao Liu <zhao1.liu@xxxxxxxxx> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, > + * or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, see <http://www.gnu.org/licenses/>. > + */ > + > +#include "qemu/osdep.h" > +#include "hw/core/cpu-topology.h" > + > +typedef struct CPUTopoInfo { > + const char *name; > +} CPUTopoInfo; > + > +CPUTopoInfo cpu_topo_descriptors[] = { > + [CPU_TOPO_LEVEL_INVALID] = { .name = "invalid", }, > + [CPU_TOPO_LEVEL_THREAD] = { .name = "thread", }, > + [CPU_TOPO_LEVEL_CORE] = { .name = "core", }, > + [CPU_TOPO_LEVEL_MODULE] = { .name = "module", }, > + [CPU_TOPO_LEVEL_CLUSTER] = { .name = "cluster", }, > + [CPU_TOPO_LEVEL_DIE] = { .name = "die", }, > + [CPU_TOPO_LEVEL_SOCKET] = { .name = "socket", }, > + [CPU_TOPO_LEVEL_BOOK] = { .name = "book", }, > + [CPU_TOPO_LEVEL_DRAWER] = { .name = "drawer", }, > + [CPU_TOPO_LEVEL_MAX] = { .name = NULL, }, > +}; > + > +const char *cpu_topo_to_string(CPUTopoLevel topo) > +{ > + return cpu_topo_descriptors[topo].name; > +} > + > +CPUTopoLevel string_to_cpu_topo(char *str) Can use const char *str. > +{ > + for (int i = 0; i < ARRAY_SIZE(cpu_topo_descriptors); i++) { > + CPUTopoInfo *info = &cpu_topo_descriptors[i]; > + > + if (!strcmp(info->name, str)) { Suggest to use strncmp instead. > + return (CPUTopoLevel)i; > + } > + } > + return CPU_TOPO_LEVEL_MAX; > +} > diff --git a/hw/core/meson.build b/hw/core/meson.build > index 67dad04de559..3b1d5ffab3e3 100644 > --- a/hw/core/meson.build > +++ b/hw/core/meson.build > @@ -23,6 +23,7 @@ else > endif > > common_ss.add(files('cpu-common.c')) > +common_ss.add(files('cpu-topology.c')) > common_ss.add(files('machine-smp.c')) > system_ss.add(when: 'CONFIG_FITLOADER', if_true: files('loader-fit.c')) > system_ss.add(when: 'CONFIG_GENERIC_LOADER', if_true: files('generic-loader.c')) > diff --git a/include/hw/core/cpu-topology.h b/include/hw/core/cpu-topology.h > new file mode 100644 > index 000000000000..cc6ca186ce3f > --- /dev/null > +++ b/include/hw/core/cpu-topology.h > @@ -0,0 +1,40 @@ > +/* > + * QEMU CPU Topology Representation Header > + * > + * Copyright (c) 2024 Intel Corporation > + * Author: Zhao Liu <zhao1.liu@xxxxxxxxx> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, > + * or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, see <http://www.gnu.org/licenses/>. > + */ > + > +#ifndef CPU_TOPOLOGY_H > +#define CPU_TOPOLOGY_H > + > +typedef enum CPUTopoLevel { > + CPU_TOPO_LEVEL_INVALID, > + CPU_TOPO_LEVEL_THREAD, > + CPU_TOPO_LEVEL_CORE, > + CPU_TOPO_LEVEL_MODULE, > + CPU_TOPO_LEVEL_CLUSTER, > + CPU_TOPO_LEVEL_DIE, > + CPU_TOPO_LEVEL_SOCKET, > + CPU_TOPO_LEVEL_BOOK, > + CPU_TOPO_LEVEL_DRAWER, > + CPU_TOPO_LEVEL_MAX, > +} CPUTopoLevel; > + > +const char *cpu_topo_to_string(CPUTopoLevel topo); > +CPUTopoLevel string_to_cpu_topo(char *str); > + > +#endif /* CPU_TOPOLOGY_H */ > diff --git a/include/hw/i386/topology.h b/include/hw/i386/topology.h > index dff49fce1154..c6ff75f23991 100644 > --- a/include/hw/i386/topology.h > +++ b/include/hw/i386/topology.h > @@ -39,7 +39,7 @@ > * CPUID Fn8000_0008_ECX[ApicIdCoreIdSize[3:0]] is set to apicid_core_width(). > */ > > - > +#include "hw/core/cpu-topology.h" > #include "qemu/bitops.h" > > /* > @@ -62,22 +62,6 @@ typedef struct X86CPUTopoInfo { > unsigned threads_per_core; > } X86CPUTopoInfo; > > -/* > - * CPUTopoLevel is the general i386 topology hierarchical representation, > - * ordered by increasing hierarchical relationship. > - * Its enumeration value is not bound to the type value of Intel (CPUID[0x1F]) > - * or AMD (CPUID[0x80000026]). > - */ > -enum CPUTopoLevel { > - CPU_TOPO_LEVEL_INVALID, > - CPU_TOPO_LEVEL_SMT, > - CPU_TOPO_LEVEL_CORE, > - CPU_TOPO_LEVEL_MODULE, > - CPU_TOPO_LEVEL_DIE, > - CPU_TOPO_LEVEL_PACKAGE, > - CPU_TOPO_LEVEL_MAX, > -}; > - > /* Return the bit width needed for 'count' IDs */ > static unsigned apicid_bitwidth_for_count(unsigned count) > { > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index ac0a10abd45f..725d7e70182d 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -247,7 +247,7 @@ static uint32_t max_thread_ids_for_cache(X86CPUTopoInfo *topo_info, > case CPU_TOPO_LEVEL_DIE: > num_ids = 1 << apicid_die_offset(topo_info); > break; > - case CPU_TOPO_LEVEL_PACKAGE: > + case CPU_TOPO_LEVEL_SOCKET: > num_ids = 1 << apicid_pkg_offset(topo_info); > break; > default: > @@ -304,7 +304,7 @@ static uint32_t num_threads_by_topo_level(X86CPUTopoInfo *topo_info, > enum CPUTopoLevel topo_level) > { > switch (topo_level) { > - case CPU_TOPO_LEVEL_SMT: > + case CPU_TOPO_LEVEL_THREAD: > return 1; Just wondering why 'return 1' is used directly for the thread, but not for the rest? > case CPU_TOPO_LEVEL_CORE: > return topo_info->threads_per_core; > @@ -313,7 +313,7 @@ static uint32_t num_threads_by_topo_level(X86CPUTopoInfo *topo_info, > case CPU_TOPO_LEVEL_DIE: > return topo_info->threads_per_core * topo_info->cores_per_module * > topo_info->modules_per_die; > - case CPU_TOPO_LEVEL_PACKAGE: > + case CPU_TOPO_LEVEL_SOCKET: > return topo_info->threads_per_core * topo_info->cores_per_module * > topo_info->modules_per_die * topo_info->dies_per_pkg; > default: > @@ -326,7 +326,7 @@ static uint32_t apicid_offset_by_topo_level(X86CPUTopoInfo *topo_info, > enum CPUTopoLevel topo_level) > { > switch (topo_level) { > - case CPU_TOPO_LEVEL_SMT: > + case CPU_TOPO_LEVEL_THREAD: > return 0; > case CPU_TOPO_LEVEL_CORE: > return apicid_core_offset(topo_info); > @@ -334,7 +334,7 @@ static uint32_t apicid_offset_by_topo_level(X86CPUTopoInfo *topo_info, > return apicid_module_offset(topo_info); > case CPU_TOPO_LEVEL_DIE: > return apicid_die_offset(topo_info); > - case CPU_TOPO_LEVEL_PACKAGE: > + case CPU_TOPO_LEVEL_SOCKET: > return apicid_pkg_offset(topo_info); > default: > g_assert_not_reached(); > @@ -347,7 +347,7 @@ static uint32_t cpuid1f_topo_type(enum CPUTopoLevel topo_level) > switch (topo_level) { > case CPU_TOPO_LEVEL_INVALID: > return CPUID_1F_ECX_TOPO_LEVEL_INVALID; > - case CPU_TOPO_LEVEL_SMT: > + case CPU_TOPO_LEVEL_THREAD: > return CPUID_1F_ECX_TOPO_LEVEL_SMT; > case CPU_TOPO_LEVEL_CORE: > return CPUID_1F_ECX_TOPO_LEVEL_CORE; > @@ -380,7 +380,7 @@ static void encode_topo_cpuid1f(CPUX86State *env, uint32_t count, > level = CPU_TOPO_LEVEL_INVALID; > for (int i = 0; i <= count; i++) { > level = find_next_bit(env->avail_cpu_topo, > - CPU_TOPO_LEVEL_PACKAGE, > + CPU_TOPO_LEVEL_SOCKET, > level + 1); > > /* > @@ -388,7 +388,7 @@ static void encode_topo_cpuid1f(CPUX86State *env, uint32_t count, > * and it just encode the invalid level (all fields are 0) > * into the last subleaf of 0x1f. > */ > - if (level == CPU_TOPO_LEVEL_PACKAGE) { > + if (level == CPU_TOPO_LEVEL_SOCKET) { > level = CPU_TOPO_LEVEL_INVALID; > break; > } > @@ -401,7 +401,7 @@ static void encode_topo_cpuid1f(CPUX86State *env, uint32_t count, > unsigned long next_level; > > next_level = find_next_bit(env->avail_cpu_topo, > - CPU_TOPO_LEVEL_PACKAGE, > + CPU_TOPO_LEVEL_SOCKET, > level + 1); > num_threads_next_level = num_threads_by_topo_level(topo_info, > next_level); > @@ -6290,7 +6290,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count, > > /* Share the cache at package level. */ > *eax |= max_thread_ids_for_cache(&topo_info, > - CPU_TOPO_LEVEL_PACKAGE) << 14; > + CPU_TOPO_LEVEL_SOCKET) << 14; > } > } > } else if (cpu->vendor_cpuid_only && IS_AMD_CPU(env)) { > @@ -7756,9 +7756,9 @@ static void x86_cpu_init_default_topo(X86CPU *cpu) > env->nr_dies = 1; > > /* SMT, core and package levels are set by default. */ > - set_bit(CPU_TOPO_LEVEL_SMT, env->avail_cpu_topo); > + set_bit(CPU_TOPO_LEVEL_THREAD, env->avail_cpu_topo); > set_bit(CPU_TOPO_LEVEL_CORE, env->avail_cpu_topo); > - set_bit(CPU_TOPO_LEVEL_PACKAGE, env->avail_cpu_topo); > + set_bit(CPU_TOPO_LEVEL_SOCKET, env->avail_cpu_topo); > } > > static void x86_cpu_initfn(Object *obj) > diff --git a/target/i386/cpu.h b/target/i386/cpu.h > index 4b4cc70c8859..fcbf278b49e6 100644 > --- a/target/i386/cpu.h > +++ b/target/i386/cpu.h > @@ -1596,7 +1596,7 @@ typedef struct CPUCacheInfo { > * Used to encode CPUID[4].EAX[bits 25:14] or > * CPUID[0x8000001D].EAX[bits 25:14]. > */ > - enum CPUTopoLevel share_level; > + CPUTopoLevel share_level; > } CPUCacheInfo; > > > diff --git a/tests/unit/meson.build b/tests/unit/meson.build > index cae925c13259..4fe0aaff3a5e 100644 > --- a/tests/unit/meson.build > +++ b/tests/unit/meson.build > @@ -138,7 +138,8 @@ if have_system > 'test-util-sockets': ['socket-helpers.c'], > 'test-base64': [], > 'test-bufferiszero': [], > - 'test-smp-parse': [qom, meson.project_source_root() / 'hw/core/machine-smp.c'], > + 'test-smp-parse': [qom, meson.project_source_root() / 'hw/core/machine-smp.c', > + meson.project_source_root() / 'hw/core/cpu-topology.c'], > 'test-vmstate': [migration, io], > 'test-yank': ['socket-helpers.c', qom, io, chardev] > } > -- > 2.34.1
