On Mon, Feb 26, 2024 at 02:03:34PM -0500, Paolo Bonzini wrote: > +``KVM_MEMORY_ENCRYPT_OP`` API > +============================= Nit: I think to be consistent, with command names in section headings below, the API name heading above should not be inlined. > > The main ioctl to access SEV is KVM_MEMORY_ENCRYPT_OP. If the argument > to KVM_MEMORY_ENCRYPT_OP is NULL, the ioctl returns 0 if SEV is enabled > @@ -87,10 +81,6 @@ guests, such as launching, running, snapshotting, migrating and decommissioning. > The KVM_SEV_INIT command is used by the hypervisor to initialize the SEV platform > context. In a typical workflow, this command should be the first command issued. > > -The firmware can be initialized either by using its own non-volatile storage or > -the OS can manage the NV storage for the firmware using the module parameter > -``init_ex_path``. If the file specified by ``init_ex_path`` does not exist or > -is invalid, the OS will create or override the file with output from PSP. > > Returns: 0 on success, -negative on error > > @@ -434,6 +424,21 @@ issued by the hypervisor to make the guest ready for execution. > > Returns: 0 on success, -negative on error > > +Firmware Management > +=================== > + > +The SEV guest key management is handled by a separate processor called the AMD > +Secure Processor (AMD-SP). Firmware running inside the AMD-SP provides a secure > +key management interface to perform common hypervisor activities such as > +encrypting bootstrap code, snapshot, migrating and debugging the guest. For more > +information, see the SEV Key Management spec [api-spec]_ > + > +The AMD-SP firmware can be initialized either by using its own non-volatile > +storage or the OS can manage the NV storage for the firmware using > +parameter ``init_ex_path`` of the ``ccp`` module. If the file specified > +by ``init_ex_path`` does not exist or is invalid, the OS will create or > +override the file with PSP non-volatile storage. > + This one LGTM. Other than the nit, Reviewed-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx> -- An old man doll... just what I always wanted! - Clara
Attachment:
signature.asc
Description: PGP signature
