Hello On Tue, Feb 27, 2024 at 10:56 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Mon, Feb 26, 2024 at 10:35:32PM +0800, Lai Jiangshan wrote: > > From: Hou Wenlong <houwenlong.hwl@xxxxxxxxxxxx> > > > > PVM needs to reserve a contiguous and aligned kernel virtual area for > > Who is "PVM", and why does it need aligned virtual memory space? PVM stands for Pagetable-based Virtual Machine. It is a new pure software-implemented virtualization solution. The details are in the cover letter: https://lore.kernel.org/lkml/20240226143630.33643-1-jiangshanlai@xxxxxxxxx/ I'm sorry for not CC'ing you on the cover letter (I haven't made/found a proper script to generate all cc-recipients for the cover letter.) nor elaborating the reason in the changelog. One of the core designs in PVM is the "Exclusive address space separation", with which in the higher half of the address spaces (where the most significant bits in the addresses are 1s), the address ranges that a PVM guest is allowed are exclusive from the host kernel. So PVM hypervisor has to use get_vm_area_align() to reserve a huge range (normally 16T) with the alignment 512G (PGDIR_SIZE) for all the guests to accommodate the whole guest kernel space. The reserved range cannot be used by the host. The rationale of this core design is also in the cover letter. Thanks Lai > > > +extern struct vm_struct *get_vm_area_align(unsigned long size, unsigned long align, > > No need for the extern here. >