On Tue, Feb 20, 2024 at 05:14:02PM +0800, Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx> wrote: > > @@ -1936,6 +1959,26 @@ int __init tdx_hardware_setup(struct kvm_x86_ops *x86_ops) > > return -EINVAL; > > } > > + for (i = 0; i < ARRAY_SIZE(tdx_uret_msrs); i++) { > > + /* > > + * Here it checks if MSRs (tdx_uret_msrs) can be saved/restored > > + * before returning to user space. > > + * > > + * this_cpu_ptr(user_return_msrs)->registered isn't checked > > + * because the registration is done at vcpu runtime by > > + * kvm_set_user_return_msr(). > > For tdx, it's done by kvm_user_return_update_cache(), right? Right, fixed the comment. -- Isaku Yamahata <isaku.yamahata@xxxxxxxxxxxxxxx>