On Mon, Feb 19, 2024 at 01:34:37PM +0100, Markus Armbruster wrote:
> Xiaoyao Li <xiaoyao.li@xxxxxxxxx> writes:
>
> > Introduce tdx-guest object which implements the interface of
> > CONFIDENTIAL_GUEST_SUPPORT, and will be used to create TDX VMs (TDs) by
> >
> > qemu -machine ...,confidential-guest-support=tdx0 \
> > -object tdx-guest,id=tdx0
> >
> > It has only one member 'attributes' with fixed value 0 and not
> > configurable so far.
>
> Really? Can't see it.
The 'attributes' referred to is an internal struct field,
rather than a QAPI declared member.
>
> Suggest to add something like "Configuration properties will be added
> later in this series."
>
> > Signed-off-by: Xiaoyao Li <xiaoyao.li@xxxxxxxxx>
> > Acked-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
> > Acked-by: Markus Armbruster <armbru@xxxxxxxxxx>
>
> [...]
>
> > diff --git a/qapi/qom.json b/qapi/qom.json
> > index 95516ba325e5..5b3c3146947f 100644
> > --- a/qapi/qom.json
> > +++ b/qapi/qom.json
> > @@ -895,6 +895,16 @@
> > 'reduced-phys-bits': 'uint32',
> > '*kernel-hashes': 'bool' } }
> >
> > +##
> > +# @TdxGuestProperties:
> > +#
> > +# Properties for tdx-guest objects.
> > +#
> > +# Since: 9.0
> > +##
> > +{ 'struct': 'TdxGuestProperties',
> > + 'data': { }}
> > +
> > ##
> > # @ThreadContextProperties:
> > #
> > @@ -974,6 +984,7 @@
> > 'sev-guest',
> > 'thread-context',
> > 's390-pv-guest',
> > + 'tdx-guest',
> > 'throttle-group',
> > 'tls-creds-anon',
> > 'tls-creds-psk',
> > @@ -1041,6 +1052,7 @@
> > 'secret_keyring': { 'type': 'SecretKeyringProperties',
> > 'if': 'CONFIG_SECRET_KEYRING' },
> > 'sev-guest': 'SevGuestProperties',
> > + 'tdx-guest': 'TdxGuestProperties',
> > 'thread-context': 'ThreadContextProperties',
> > 'throttle-group': 'ThrottleGroupProperties',
> > 'tls-creds-anon': 'TlsCredsAnonProperties',
>
> [...]
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
