> From: Yishai Hadas <yishaih@xxxxxxxxxx>
> Sent: Monday, February 5, 2024 5:21 PM
>
> On 05/02/2024 10:10, Tian, Kevin wrote:
> >> From: Yishai Hadas <yishaih@xxxxxxxxxx>
> >> Sent: Wednesday, January 31, 2024 1:02 AM
> >>
> >> +static void set_tracker_event(struct mlx5vf_pci_core_device *mvdev)
> >> +{
> >> + mvdev->tracker.event_occur = true;
> >> + complete(&mvdev->tracker_comp);
> >
> > it's slightly clearer to call it 'object_changed'.
>
> Do you refer to the 'event_occur' field ? I can rename it, if you think
> that it's clearer.
yes
>
> >
> > and why not setting state->is_err too?
>
> No need for an extra code here.
>
> Upon mlx5vf_cmd_query_tracker() the tracker->status field will be
> updated to an error, the while loop will detect that, and do the job.
>
except below where tracker->status is not updated:
+ err = mlx5_cmd_exec(mdev, in, sizeof(in), out, sizeof(out));
+ if (err)
+ return err;
