Re: Re: [PATCH 5/5] KVM: selftests: x86_64: Remove redundant newlines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 30, 2024 at 12:26:25PM -0800, Sean Christopherson wrote:
> On Wed, Dec 06, 2023, Andrew Jones wrote:
> > @@ -162,7 +162,7 @@ static void check_clocksource(void)
> >  		goto out;
> >  	}
> >  
> > -	TEST_ASSERT(!strncmp(clk_name, "tsc\n", st.st_size),
> > +	TEST_ASSERT(!strncmp(clk_name, "tsc", st.st_size),
> 
> This newline is functionally necessary.  It's in the strncmp() (*#$@ sysfs appends
> newlines to everything), not the TEST_ASSERT message.  I'll give you a pass and
> fixup when applying since I'm guessing you don't have x86 hardware ;-)

Thanks for the fixup!

> 
> I double checked the other arch patches and didn't see anything sneaky like this.

And for the double check!

drew




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux