Re: [PATCH v3 22/29] target/riscv: Prefer fast cpu_env() over slower CPU QOM cast macro

Subject: Re: [PATCH v3 22/29] target/riscv: Prefer fast cpu_env() over slower CPU QOM cast macro
From: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
Date: Tue, 30 Jan 2024 09:35:03 +0100
Cc: qemu-riscv@xxxxxxxxxx, qemu-s390x@xxxxxxxxxx, Paolo Bonzini <pbonzini@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, qemu-ppc@xxxxxxxxxx, qemu-arm@xxxxxxxxxx, Richard Henderson <richard.henderson@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Bin Meng <bin.meng@xxxxxxxxxxxxx>, Weiwei Li <liwei1518@xxxxxxxxx>, Liu Zhiwei <zhiwei_liu@xxxxxxxxxxxxxxxxx>
In-reply-to: <c1604184-d470-43ef-9530-cb8c0e5c8901@ventanamicro.com>
References: <20240129164514.73104-1-philmd@linaro.org> <20240129164514.73104-23-philmd@linaro.org> <c1604184-d470-43ef-9530-cb8c0e5c8901@ventanamicro.com>
User-agent: Mozilla Thunderbird

On 29/1/24 22:53, Daniel Henrique Barboza wrote:

Hey Phil,
This patch is giving me a conflict in target/riscv/cpu_helper.c whenapplying
on top of master. Not sure if I'm missing any dependency.


My 'master' was commit 7a1dc45af5.

It's a trivial conflict though, just a FYI. As for the patch:


Reviewed-by: Daniel Henrique Barboza <dbarboza@xxxxxxxxxxxxxxxx>


Thanks!

References:
- [PATCH v3 00/29] hw,target: Prefer fast cpu_env() over slower CPU QOM cast macro
  - From: Philippe Mathieu-Daudé
- [PATCH v3 22/29] target/riscv: Prefer fast cpu_env() over slower CPU QOM cast macro
  - From: Philippe Mathieu-Daudé
- Re: [PATCH v3 22/29] target/riscv: Prefer fast cpu_env() over slower CPU QOM cast macro
  - From: Daniel Henrique Barboza