On Thu, Jan 25, 2024 at 12:59 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > On Thu, Jan 25, 2024, Brilliant Hanabi wrote: > > Thanks for your review. In my opinion, it is better to avoid potential bugs > > which is difficult to detect, as long as you can return errors to let > > developers know about them in advance, although the kernel is not to blame > > for this bug. > > Oh, I completely agree that explict errors are far better. My only concern is > that there's a teeny tiny chance that rejecting an ioctl() that used to work > could break userspace. > > Go ahead and send v2. I'll get Paolo's thoughts on whether or not this is likely > to break userspace and we can go from there. I share the same worry but I agree it's quite unlikely. Let's just do it, and if someone complains we'll revert it. Paolo
