On Thu, Jan 25, 2024 at 11:02:01AM +0000, Marc Zyngier wrote: [...] > > I would've liked to have benchmark data showing the improvement on top > > of upstream with this series, but I'm currently having issues with our > > internal infrastructure and upstream kernels. However, this series has > > been found to have a near 2x performance improvement to redis-memtier [*] > > benchmarks on our kernel tree. > > It'd be really good to have upstream-based numbers, with details of > the actual setup (device assignment? virtio?) so that we can compare > things and even track regressions in the future. Yeah, that sort of thing isn't optional IMO, I just figured that getting reviews on this would be a bit more productive while I try and recreate the test correctly on top of upstream. The test setup I based my "2x" statement on is 4 16 vCPU client VMs talking to 1 16 vCPU server VM over NIC VFs assigned to the respective VMs. 16 TX + 16 RX queues for each NIC. As I'm sure you're aware, I know damn near nothing about the Redis setup itself, and I'll need to do a bit of work to translate the thing I was using into a script. -- Thanks, Oliver
