Re: [kvm-unit-tests PATCH v2 2/3] runtime: arm64: Skip the migration tests when run on EFI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 29, 2023 at 10:29:39PM -0500, Shaoqin Huang wrote:
> When running the migration tests on EFI, the migration will always fail
> since the efi/run use the vvfat format to run test, but the vvfat format
> does not support live migration. So those migration tests will always
> fail.
> 
> Instead of waiting for fail everytime when run migration tests on EFI,
> skip those tests if running on EFI.
> 
> Signed-off-by: Shaoqin Huang <shahuang@xxxxxxxxxx>
> ---
>  scripts/runtime.bash | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
> index c73fb024..64d223e8 100644
> --- a/scripts/runtime.bash
> +++ b/scripts/runtime.bash
> @@ -156,6 +156,10 @@ function run()
>  
>      cmdline=$(get_cmdline $kernel)
>      if find_word "migration" "$groups"; then
> +        if [ "{CONFIG_EFI}" == "y" ]; then
> +            print_result "SKIP" $testname "" "migration tests are not supported with efi"
> +            return 2
> +        fi
>          cmdline="MIGRATION=yes $cmdline"
>      fi
>      if find_word "panic" "$groups"; then
> -- 
> 2.40.1
> 

This isn't arm-specific, so we should drop the arm64 prefix from the patch
summary and get an ack from x86 people.

Thanks,
drew




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux