Re: linux-next: Tree for Jan 8 (drivers/vfio/pci/virtio/main.o)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 1/7/24 21:09, Stephen Rothwell wrote:
> Hi all,
> 
> News: the merge window has opened, so please do not add any material
> intended for v6.9 to your linux-next included branches until asfter
> v6.8-rc1 has been released.
> 
> Changes since 20240105:
> 

on powerpc 64-bit:

when
CONFIG_VIRTIO_PCI=m
CONFIG_VIRTIO_PCI_ADMIN_LEGACY=y


powerpc64-linux-ld: drivers/vfio/pci/virtio/main.o: in function `virtiovf_pci_probe':
main.c:(.text+0x17c): undefined reference to `virtio_pci_admin_has_legacy_io'
powerpc64-linux-ld: drivers/vfio/pci/virtio/main.o: in function `virtiovf_pci_init_device':
main.c:(.text+0x82c): undefined reference to `virtio_pci_admin_legacy_io_notify_info'
powerpc64-linux-ld: drivers/vfio/pci/virtio/main.o: in function `virtiovf_pci_bar0_rw':
main.c:(.text+0xe98): undefined reference to `virtio_pci_admin_legacy_common_io_read'
powerpc64-linux-ld: main.c:(.text+0xecc): undefined reference to `virtio_pci_admin_legacy_device_io_read'
powerpc64-linux-ld: main.c:(.text+0x10d8): undefined reference to `virtio_pci_admin_legacy_common_io_write'
powerpc64-linux-ld: main.c:(.text+0x1108): undefined reference to `virtio_pci_admin_legacy_device_io_write'


Also, it is not a good idea to have a driver depend on a hidden (not visible) Kconfig symbol,
like this:

config VIRTIO_VFIO_PCI
        tristate "VFIO support for VIRTIO NET PCI devices"
        depends on VIRTIO_PCI_ADMIN_LEGACY


Full randconfig file is attached.

-- 
#Randy

Attachment: config-r4841.gz
Description: application/gzip


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux