On Fri, Jan 5, 2024 at 6:29 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > On Fri, Jan 05, 2024, Linus Torvalds wrote: > > On Thu, 4 Jan 2024 at 07:48, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > > > > > * Fix Boolean logic in intel_guest_get_msrs > > > > I think the intention of the original was to write this as > > > > .guest = intel_ctrl & ~(cpuc->intel_ctrl_host_mask | pebs_mask), > > > > but your version certainly works too. > > Ha! That's what I suggested too, clearly Paolo is the weird one :-) Not that I don't like your version; but since you hadn't provided (yet) a Signed-off-by I had not looked at the patch until now. In the end it's a coin toss between "fix what was clearly intended" and "restore the logic before the broken commit". I picked the latter because when trying to reverse engineer Linus's brain processes I tend to overthink these things. :) That counts as being weird, I guess. Paolo
