On 12/26/23 17:11, Huacai Chen wrote: > Hi, Randy, > > Could you please fix kvm_own_lsx() together? > Sure will. Thanks. > Huacai > > On Wed, Dec 27, 2023 at 9:07 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: >> >> The stub for kvm_own_lasx() when CONFIG_CPU_HAS_LASX is not defined >> should have a return value since it returns an int, so add >> "return -EINVAL;" to the stub. Fixes the build error: >> >> In file included from ../arch/loongarch/include/asm/kvm_csr.h:12, >> from ../arch/loongarch/kvm/interrupt.c:8: >> ../arch/loongarch/include/asm/kvm_vcpu.h: In function 'kvm_own_lasx': >> ../arch/loongarch/include/asm/kvm_vcpu.h:73:39: error: no return statement in function returning non-void [-Werror=return-type] >> 73 | static inline int kvm_own_lasx(struct kvm_vcpu *vcpu) { } >> >> Fixes: 118e10cd893d ("LoongArch: KVM: Add LASX (256bit SIMD) support") >> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >> Cc: Bibo Mao <maobibo@xxxxxxxxxxx> >> Cc: Tianrui Zhao <zhaotianrui@xxxxxxxxxxx> >> Cc: Huacai Chen <chenhuacai@xxxxxxxxxxx> >> Cc: WANG Xuerui <kernel@xxxxxxxxxx> >> Cc: kvm@xxxxxxxxxxxxxxx >> Cc: loongarch@xxxxxxxxxxxxxxx >> Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> >> --- -- #Randy