> From: Liu, Yi L <yi.l.liu@xxxxxxxxx> > Sent: Thursday, December 21, 2023 11:40 PM > + > + > + if ((inv.flags & IOMMU_TEST_INVALIDATE_FLAG_ALL) && > + (inv.flags & > IOMMU_TEST_INVALIDATE_FLAG_TRIGGER_ERROR)) { > + rc = -EINVAL; > + break; > + } > + a nit. is there a reason why the two flags can not be set together? in concept a mock iommu error could occur in either invalidate-one or invalidate-all. otherwise, Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>