Cleber Rosa <crosa@xxxxxxxxxx> writes: > Marcin Juszkiewicz <marcin.juszkiewicz@xxxxxxxxxx> writes: > >> W dniu 8.12.2023 o 20:09, Cleber Rosa pisze: >>> The tests under machine_aarch64_virt.py do not need read-write access >>> to the ISOs. The ones under machine_aarch64_sbsaref.py, on the other >>> hand, will need read-write access, so let's give each test an unique >>> file. >>> >>> And while at it, let's use a single code style and hash for the ISO >>> url. >>> >>> Signed-off-by: Cleber Rosa<crosa@xxxxxxxxxx> >> >> It is ISO file, so sbsa-ref tests should be fine with readonly as well. >> >> Nothing gets installed so nothing is written. We only test does boot works. > > That was my original expectation too. But, with nothing but the > following change: > > diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py > index 528c7d2934..436da4b156 100644 > --- a/tests/avocado/machine_aarch64_sbsaref.py > +++ b/tests/avocado/machine_aarch64_sbsaref.py > @@ -129,7 +129,7 @@ def boot_alpine_linux(self, cpu): > "-cpu", > cpu, > "-drive", > - f"file={iso_path},format=raw", > + f"file={iso_path},readonly=on,format=raw", f"file={iso_path},readonly=on,media=cdrom,format=raw", works (although possible the readonly is redundant in this case). > "-device", > "virtio-rng-pci,rng=rng0", > "-object", > > We get: > > 15:55:10 DEBUG| VM launch command: './qemu-system-aarch64 -display none -vga none -chardev socket,id=mon,fd=15 -mon chardev=mon,mode=control -machine sbsa-ref - > chardev socket,id=console,fd=20 -serial chardev:console -cpu cortex-a57 -drive if=pflash,file=/home/cleber/avocado/job-results/job-2023-12-13T15.55-28ef2b5/test > -results/tmp_dirx8p5xzt4/1-tests_avocado_machine_aarch64_sbsaref.py_Aarch64SbsarefMachine.test_sbsaref_alpine_linux_cortex_a57/SBSA_FLASH0.fd,format=raw -drive > if=pflash,file=/home/cleber/avocado/job-results/job-2023-12-13T15.55-28ef2b5/test-results/tmp_dirx8p5xzt4/1-tests_avocado_machine_aarch64_sbsaref.py_Aarch64Sbsa > refMachine.test_sbsaref_alpine_linux_cortex_a57/SBSA_FLASH1.fd,format=raw -smp 1 -machine sbsa-ref -cpu cortex-a57 -drive file=/home/cleber/avocado/data/cache/b > y_location/0154b7cd3a4f5e135299060c8cabbeec10b70b6d/alpine-standard-3.17.2-aarch64.iso,readonly=on,format=raw -device virtio-rng-pci,rng=rng0 -object rng-random > ,id=rng0,filename=/dev/urandom' > > Followed by: > > 15:55:10 DEBUG| Failed to establish session: > | Traceback (most recent call last): > | File "/home/cleber/src/qemu/python/qemu/qmp/protocol.py", line 425, in _session_guard > | await coro > | File "/home/cleber/src/qemu/python/qemu/qmp/qmp_client.py", line 253, in _establish_session > | await self._negotiate() > | File "/home/cleber/src/qemu/python/qemu/qmp/qmp_client.py", line 305, in _negotiate > | reply = await self._recv() > | ^^^^^^^^^^^^^^^^^^ > | File "/home/cleber/src/qemu/python/qemu/qmp/protocol.py", line 1009, in _recv > | message = await self._do_recv() > | ^^^^^^^^^^^^^^^^^^^^^ > | File "/home/cleber/src/qemu/python/qemu/qmp/qmp_client.py", line 402, in _do_recv > | msg_bytes = await self._readline() > | ^^^^^^^^^^^^^^^^^^^^^^ > | File "/home/cleber/src/qemu/python/qemu/qmp/protocol.py", line 977, in _readline > | raise EOFError > | EOFError > > With qemu-system-arch producing on stdout: > > qemu-system-aarch64: Block node is read-only > > Any ideas on the reason or cause? > > Thanks, > - Cleber. -- Alex Bennée Virtualisation Tech Lead @ Linaro