Re: [PATCH RFC] KVM MMU: fix hashing for TDP and non-paging modes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 26, 2010 at 06:30:00PM -0300, Marcelo Tosatti wrote:
> > @@ -2089,6 +2089,10 @@ static int mmu_alloc_roots(struct kvm_vcpu *vcpu)
> >                         root_gfn = 0;
> >                 if (mmu_check_root(vcpu, root_gfn))
> >                         return 1;
> > +               if (tdp_enabled) {
> > +                       direct = 1;
> > +                       root_gfn = i << 30;
> > +               }
> >                 sp = kvm_mmu_get_page(vcpu, root_gfn, i << 30,
> >                                       PT32_ROOT_LEVEL, direct,
> >                                       ACC_ALL, NULL);
> 
> There is no need to allocate 4 different roots for TDP tables if
> kvm_x86_ops->get_tdp_level() == PT64_ROOT_LEVEL.

Doh, and your patch does not. But it does not apply to kvm.git -next 
branch, can you regenerate please?

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux