On 12/7/2023 3:51 AM, Dionna Amalie Glaze wrote: >> >> +static void __init set_secrets_pa(const struct cc_blob_sev_info *cc_info) >> +{ >> + if (cc_info && cc_info->secrets_phys && cc_info->secrets_len == PAGE_SIZE) >> + secrets_pa = cc_info->secrets_phys; >> +} > > I know failure leads to an -ENODEV later on init_platform, but a > missing secrets page as a symptom seems like a good thing to log, > right? Added in the next patch. + if (!secrets_pa) { + pr_err("SNP secrets page not found\n"); return -ENODEV; + } > >> - if (!gpa) >> + if (!secrets_pa) >> return -ENODEV; >> > > Regards Nikunj