On Tue, Dec 05, 2023 at 08:33:14PM +0000, Huang, Kai wrote: > Yes I understand what you said. My point is X86_FEATURE_TDX doesn't suit > because when it is set, the kernel actually hasn't done any enabling work yet > thus TDX is not available albeit the X86_FEATURE_TDX is set. You define a X86_FEATURE flag. You set it *when* TDX is available and enabled. Then you query that flag. This is how synthetic flags work. In your patchset, when do you know that TDX is enabled? Point me to the code place pls. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette