On 11/21/2023 10:50 AM, Yahui Cao wrote:
This series adds vfio live migration support for Intel E810 VF devices
based on the v2 migration protocol definition series discussed here[0].
Steps to test:
1. Bind one or more E810 VF devices to the module ice-vfio-pci.ko
2. Assign the VFs to the virtual machine and enable device live migration
3. Run a workload using IAVF inside the VM, for example, iperf.
4. Migrate the VM from the source node to a destination node.
The series is also available for review here[1].
Thanks,
Yahui
[0] https://lore.kernel.org/kvm/20220224142024.147653-1-yishaih@xxxxxxxxxx/
[1] https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/linux.git/log/?h=ice_live_migration
Change log:
v4:
- Remove unnecessary iomap from vfio variant driver
- Change Kconfig to select VFIO_PCI_CORE for ICE_VFIO_PCI module (Alex)
- Replace restore state with load state for naming convention
- Remove RXDID Patch
- Fix missed comments in Patch03
- Remove "so" at the beginning of the sentence and fix other grammar issue.
- Remove double init and change return logic for Patch 10
- Change ice_migration_unlog_vf_msg comments for Patch04
- Add r-b from Michal to Patch04 of v4
- Change ice_migration_is_loggable_msg return value type into bool type for Patch05
- Change naming from dirtied to dirty for Patch11
- Use total_length to pass parameter to save/load function instead of macro for Patch12
- Refactor timeout logic for Patch09
- Change migration_enabled from bool into u8:1 type for Patch04
- Fix 80 max line length limit issue and compilation warning
- Add r-b from Igor to all the patches of v4
- Fix incorrect type in assignment of __le16/32 for Patch06
- Change product name to from E800 to E810
v3: https://lore.kernel.org/intel-wired-lan/20230918062546.40419-1-yahui.cao@xxxxxxxxx/
- Add P2P support in vfio driver (Jason)
- Remove source/destination check in vfio driver (Jason)
- Restructure PF exported API with proper types and layering (Jason)
- Change patchset email sender.
- Reword commit message and comments to be more reviewer-friendly (Kevin)
- Add s-o-b for Patch01 (Kevin)
- Merge Patch08 into Patch04 and merge Patch13 into Patch06 (Kevin)
- Remove uninit() in VF destroy stage for Patch 05 (Kevin)
- change migration_active to migration_enabled (Kevin)
- Add total_size in devstate to greatly simplify the various checks for
Patch07 (Kevin)
- Add magic and version in device state for Patch07 (Kevin)
- Fix rx head init issue in Patch10 (Kevin)
- Remove DMA access for Guest Memory at device resume stage and deprecate
the approach to restore TX head in VF space, instead restore TX head in
PF space and then switch context back to VF space which is transparent
to Guest for Patch11 (Jason, Kevin)
- Use non-interrupt mode instead of VF MSIX vector to restore TX head for
Patch11 (Kevin)
- Move VF pci mmio save/restore from vfio driver into PF driver
- Add configuration match check at device resume stage (Kevin)
- Remove sleep before stopping queue at device suspend stage (Kevin)
- Let PF respond failure to VF if virtual channel messages logging failed (Kevin)
- Add migration setup and description in cover letter
v2: https://lore.kernel.org/intel-wired-lan/20230621091112.44945-1-lingyu.liu@xxxxxxxxx/
- clarified comments and commit message
v1: https://lore.kernel.org/intel-wired-lan/20230620100001.5331-1-lingyu.liu@xxxxxxxxx/
---
Lingyu Liu (9):
ice: Introduce VF state ICE_VF_STATE_REPLAYING_VC for migration
ice: Add fundamental migration init and exit function
ice: Log virtual channel messages in PF
ice: Add device state save/load function for migration
ice: Fix VSI id in virtual channel message for migration
ice: Save and load RX Queue head
ice: Save and load TX Queue head
ice: Add device suspend function for migration
vfio/ice: Implement vfio_pci driver for E800 devices
Yahui Cao (3):
ice: Add function to get RX queue context
ice: Add function to get and set TX queue context
ice: Save and load mmio registers
MAINTAINERS | 7 +
drivers/net/ethernet/intel/ice/Makefile | 1 +
drivers/net/ethernet/intel/ice/ice.h | 3 +
drivers/net/ethernet/intel/ice/ice_common.c | 484 +++++-
drivers/net/ethernet/intel/ice/ice_common.h | 11 +
.../net/ethernet/intel/ice/ice_hw_autogen.h | 23 +
.../net/ethernet/intel/ice/ice_lan_tx_rx.h | 3 +
drivers/net/ethernet/intel/ice/ice_main.c | 15 +
.../net/ethernet/intel/ice/ice_migration.c | 1378 +++++++++++++++++
.../intel/ice/ice_migration_private.h | 49 +
drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 +
drivers/net/ethernet/intel/ice/ice_vf_lib.h | 11 +
drivers/net/ethernet/intel/ice/ice_virtchnl.c | 256 ++-
drivers/net/ethernet/intel/ice/ice_virtchnl.h | 15 +-
.../ethernet/intel/ice/ice_virtchnl_fdir.c | 28 +-
drivers/vfio/pci/Kconfig | 2 +
drivers/vfio/pci/Makefile | 2 +
drivers/vfio/pci/ice/Kconfig | 10 +
drivers/vfio/pci/ice/Makefile | 4 +
drivers/vfio/pci/ice/ice_vfio_pci.c | 707 +++++++++
include/linux/net/intel/ice_migration.h | 48 +
21 files changed, 2962 insertions(+), 99 deletions(-)
create mode 100644 drivers/net/ethernet/intel/ice/ice_migration.c
create mode 100644 drivers/net/ethernet/intel/ice/ice_migration_private.h
create mode 100644 drivers/vfio/pci/ice/Kconfig
create mode 100644 drivers/vfio/pci/ice/Makefile
create mode 100644 drivers/vfio/pci/ice/ice_vfio_pci.c
create mode 100644 include/linux/net/intel/ice_migration.h
Hey Jason & Alex,
Did you have any chance to review this v4 patchset ?
The branch is published as
https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/linux.git/log/?h=ice_live_migration
as requested.
These patches are based on top of commit b85ea95d0864 ("Linux
6.7-rc1") and being sent as a whole for ease of review. A branch/shared
pull request for the networking portion of these patches (1-11) will be
sent when review is complete.
Thanks.
Yahui.
