Xiaoyao Li <xiaoyao.li@xxxxxxxxx> writes: > From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx> > > Three sha384 hash values, mrconfigid, mrowner and mrownerconfig, of a TD > can be provided for TDX attestation. > > So far they were hard coded as 0. Now allow user to specify those values > via property mrconfigid, mrowner and mrownerconfig. They are all in > base64 format. > > example > -object tdx-guest, \ > mrconfigid=ASNFZ4mrze8BI0VniavN7wEjRWeJq83vASNFZ4mrze8BI0VniavN7wEjRWeJq83v,\ > mrowner=ASNFZ4mrze8BI0VniavN7wEjRWeJq83vASNFZ4mrze8BI0VniavN7wEjRWeJq83v,\ > mrownerconfig=ASNFZ4mrze8BI0VniavN7wEjRWeJq83vASNFZ4mrze8BI0VniavN7wEjRWeJq83v > > Signed-off-by: Isaku Yamahata <isaku.yamahata@xxxxxxxxx> > Co-developed-by: Xiaoyao Li <xiaoyao.li@xxxxxxxxx> > Signed-off-by: Xiaoyao Li <xiaoyao.li@xxxxxxxxx> > --- > Changes in v3: > - use base64 encoding instread of hex-string; > --- > qapi/qom.json | 11 +++++- > target/i386/kvm/tdx.c | 85 +++++++++++++++++++++++++++++++++++++++++++ > target/i386/kvm/tdx.h | 3 ++ > 3 files changed, 98 insertions(+), 1 deletion(-) > > diff --git a/qapi/qom.json b/qapi/qom.json > index 3a29659e0155..fd99aa1ff8cc 100644 > --- a/qapi/qom.json > +++ b/qapi/qom.json > @@ -888,10 +888,19 @@ > # pages. Some guest OS (e.g., Linux TD guest) may require this to > # be set, otherwise they refuse to boot. > # > +# @mrconfigid: base64 encoded MRCONFIGID SHA384 digest > +# > +# @mrowner: base64 encoded MROWNER SHA384 digest > +# > +# @mrownerconfig: base64 MROWNERCONFIG SHA384 digest Can we come up with a description that tells the user a bit more clearly what we're talking about? Perhaps starting with this question could lead us there: what's an MRCONFIGID, and why should I care? > +# > # Since: 8.2 > ## > { 'struct': 'TdxGuestProperties', > - 'data': { '*sept-ve-disable': 'bool' } } > + 'data': { '*sept-ve-disable': 'bool', > + '*mrconfigid': 'str', > + '*mrowner': 'str', > + '*mrownerconfig': 'str' } } > > ## > # @ThreadContextProperties: [...]