On Thu, Nov 30, 2023 at 02:47:49PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Stefan,
>
> On 29/11/23 22:26, Stefan Hajnoczi wrote:
> > The term "iothread lock" is obsolete. The APIs use Big QEMU Lock (BQL)
> > in their names. Update the code comments to use "BQL" instead of
> > "iothread lock".
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
> > ---
> > docs/devel/reset.rst | 2 +-
> > hw/display/qxl.h | 2 +-
> > include/exec/cpu-common.h | 2 +-
> > include/exec/memory.h | 4 ++--
> > include/exec/ramblock.h | 2 +-
> > include/migration/register.h | 8 ++++----
> > target/arm/internals.h | 4 ++--
> > accel/tcg/cputlb.c | 4 ++--
> > accel/tcg/tcg-accel-ops-icount.c | 2 +-
> > hw/remote/mpqemu-link.c | 2 +-
> > migration/block-dirty-bitmap.c | 10 +++++-----
> > migration/block.c | 24 ++++++++++++------------
> > migration/colo.c | 2 +-
> > migration/migration.c | 2 +-
> > migration/ram.c | 4 ++--
> > system/physmem.c | 6 +++---
> > target/arm/helper.c | 2 +-
> > target/arm/tcg/m_helper.c | 2 +-
> > ui/spice-core.c | 2 +-
> > util/rcu.c | 2 +-
> > audio/coreaudio.m | 4 ++--
> > ui/cocoa.m | 6 +++---
> > 22 files changed, 49 insertions(+), 49 deletions(-)
>
>
> > diff --git a/include/exec/ramblock.h b/include/exec/ramblock.h
> > index 69c6a53902..a2bc0a345d 100644
> > --- a/include/exec/ramblock.h
> > +++ b/include/exec/ramblock.h
> > @@ -34,7 +34,7 @@ struct RAMBlock {
> > ram_addr_t max_length;
> > void (*resized)(const char*, uint64_t length, void *host);
> > uint32_t flags;
> > - /* Protected by iothread lock. */
> > + /* Protected by BQL. */
>
> There is only one single BQL, so preferably:
>
> "by the BQL"
>
> > char idstr[256];
> > /* RCU-enabled, writes protected by the ramlist lock */
> > QLIST_ENTRY(RAMBlock) next;
>
>
>
>
> > -/* Called with iothread lock taken. */
> > +/* Called with BQL taken. */
>
> "with the BQL" (other uses)
I will try to change these for v2. It's a pre-existing issue though
because there was only ever one "iothread lock" too.
Stefan
Attachment:
signature.asc
Description: PGP signature
