Re: [PATCH 6/6] Rename "QEMU global mutex" to "BQL" in comments and docs

Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> · Thu, 30 Nov 2023 14:49:48 +0100

On 29/11/23 22:26, Stefan Hajnoczi wrote:
The term "QEMU global mutex" is identical to the more widely used Big
QEMU Lock ("BQL"). Update the code comments and documentation to use
"BQL" instead of "QEMU global mutex".

Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
---
  docs/devel/multi-thread-tcg.rst   |  7 +++----
  docs/devel/qapi-code-gen.rst      |  2 +-
  docs/devel/replay.rst             |  2 +-
  docs/devel/multiple-iothreads.txt | 16 ++++++++--------
  include/block/blockjob.h          |  6 +++---
  include/io/task.h                 |  2 +-
  include/qemu/coroutine-core.h     |  2 +-
  include/qemu/coroutine.h          |  2 +-
  hw/block/dataplane/virtio-blk.c   |  8 ++++----
  hw/block/virtio-blk.c             |  2 +-
  hw/scsi/virtio-scsi-dataplane.c   |  6 +++---
  net/tap.c                         |  2 +-
  12 files changed, 28 insertions(+), 29 deletions(-)

diff --git a/include/block/blockjob.h b/include/block/blockjob.h
index e594c10d23..b2bc7c04d6 100644
--- a/include/block/blockjob.h
+++ b/include/block/blockjob.h
@@ -54,7 +54,7 @@ typedef struct BlockJob {
  
      /**
       * Speed that was set with @block_job_set_speed.
-     * Always modified and read under QEMU global mutex (GLOBAL_STATE_CODE).
+     * Always modified and read under BQL (GLOBAL_STATE_CODE).

"under the BQL"

       */
      int64_t speed;
  
@@ -66,7 +66,7 @@ typedef struct BlockJob {
  
      /**
       * Block other operations when block job is running.
-     * Always modified and read under QEMU global mutex (GLOBAL_STATE_CODE).
+     * Always modified and read under BQL (GLOBAL_STATE_CODE).

Ditto,

       */
      Error *blocker;
  
@@ -89,7 +89,7 @@ typedef struct BlockJob {
  
      /**
       * BlockDriverStates that are involved in this block job.
-     * Always modified and read under QEMU global mutex (GLOBAL_STATE_CODE).
+     * Always modified and read under BQL (GLOBAL_STATE_CODE).

Ditto.

       */
      GSList *nodes;
  } BlockJob;

Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>








