Re: [kvm-unit-tests PATCH v1 2/3] runtime: arm64: Skip the migration tests when run on EFI

[Andrew Jones <andrew.jones@xxxxxxxxx>]

On Tue, Nov 28, 2023 at 10:21:22PM -0500, Shaoqin Huang wrote:
> When running the migration tests on EFI, the migration will always fail
> since the efi/run use the vvfat format to run test, but the vvfat format
> does not support live migration. So those migration tests will always
> fail.
> 
> Instead of waiting for fail everytime when run migration tests on EFI,
> skip those tests if running on EFI.
> 
> Signed-off-by: Shaoqin Huang <shahuang@xxxxxxxxxx>
> ---
>  scripts/runtime.bash | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
> index d7054b80..b7105c19 100644
> --- a/scripts/runtime.bash
> +++ b/scripts/runtime.bash
> @@ -156,6 +156,11 @@ function run()
>          fi
>      }
>  
> +    if [ "${CONFIG_EFI}" == "y" ] && find_word "migration" "$groups"; then
> +        print_result "SKIP" $testname "" "migration test is not support in efi"

migration tests are not supported with efi

> +        return 2
> +    fi
> +
>      cmdline=$(get_cmdline $kernel)
>      if find_word "migration" "$groups"; then
>          cmdline="MIGRATION=yes $cmdline"


We don't need to do the find_word twice,

      cmdline=$(get_cmdline $kernel)
      if find_word "migration" "$groups"; then
          if [ "${CONFIG_EFI}" == "y" ]; then
	      print_result "SKIP" $testname "" "migration tests are not supported with efi"
	      return 2
	  fi
          cmdline="MIGRATION=yes $cmdline"

> -- 
> 2.40.1
> 

Thanks,
drew