Re: [kvm-unit-tests PATCH v1 1/3] runtime: Fix the missing last_line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 28, 2023 at 10:21:21PM -0500, Shaoqin Huang wrote:
> The last_line is deleted by the 2607d2d6 ("arm64: Add an efi/run script").
> This lead to when SKIP test, the reason is missing. Fix the problem by
> adding last_line back.
> 
> Signed-off-by: Shaoqin Huang <shahuang@xxxxxxxxxx>

Fixes: 2607d2d6 ("arm64: Add an efi/run script")

> ---
>  scripts/runtime.bash | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
> index fc156f2f..d7054b80 100644
> --- a/scripts/runtime.bash
> +++ b/scripts/runtime.bash
> @@ -148,6 +148,8 @@ function run()
>              fi
>          fi
>  
> +	last_line=$(tail -1 <<<"$log")
> +
>          if [ ${skip} == true ]; then
>              print_result "SKIP" $testname "" "$last_line"

We can just change this one use of $last_line to $(tail -1 <<<"$log")

>              return 77
> -- 
> 2.40.1
>

Thanks,
drew




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux