On Fri, Nov 10, 2023 at 03:55:20PM -0800, Sean Christopherson wrote: >As the first step toward replacing KVM's so-called "governed features" >framework with a more comprehensive, less poorly named implementation, >replace the "kvm_governed_feature" function prefix with "guest_cpu_cap" >and rename guest_can_use() to guest_cpu_cap_has(). > >The "guest_cpu_cap" naming scheme mirrors that of "kvm_cpu_cap", and >provides a more clear distinction between guest capabilities, which are >KVM controlled (heh, or one might say "governed"), and guest CPUID, which >with few exceptions is fully userspace controlled. > >No functional change intended. > >Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx> >--- > arch/x86/kvm/cpuid.c | 2 +- > arch/x86/kvm/cpuid.h | 12 ++++++------ > arch/x86/kvm/mmu/mmu.c | 4 ++-- > arch/x86/kvm/svm/nested.c | 22 +++++++++++----------- > arch/x86/kvm/svm/svm.c | 26 +++++++++++++------------- > arch/x86/kvm/svm/svm.h | 4 ++-- > arch/x86/kvm/vmx/nested.c | 6 +++--- > arch/x86/kvm/vmx/vmx.c | 14 +++++++------- > arch/x86/kvm/x86.c | 4 ++-- > 9 files changed, 47 insertions(+), 47 deletions(-) > >diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c >index dda6fc4cfae8..4f464187b063 100644 >--- a/arch/x86/kvm/cpuid.c >+++ b/arch/x86/kvm/cpuid.c >@@ -345,7 +345,7 @@ static void kvm_vcpu_after_set_cpuid(struct kvm_vcpu *vcpu) > allow_gbpages = tdp_enabled ? boot_cpu_has(X86_FEATURE_GBPAGES) : > guest_cpuid_has(vcpu, X86_FEATURE_GBPAGES); > if (allow_gbpages) >- kvm_governed_feature_set(vcpu, X86_FEATURE_GBPAGES); >+ guest_cpu_cap_set(vcpu, X86_FEATURE_GBPAGES); > > best = kvm_find_cpuid_entry(vcpu, 1); > if (best && apic) { >diff --git a/arch/x86/kvm/cpuid.h b/arch/x86/kvm/cpuid.h >index 0b90532b6e26..245416ffa34c 100644 >--- a/arch/x86/kvm/cpuid.h >+++ b/arch/x86/kvm/cpuid.h >@@ -254,7 +254,7 @@ static __always_inline bool kvm_is_governed_feature(unsigned int x86_feature) > return kvm_governed_feature_index(x86_feature) >= 0; > } > >-static __always_inline void kvm_governed_feature_set(struct kvm_vcpu *vcpu, >+static __always_inline void guest_cpu_cap_set(struct kvm_vcpu *vcpu, > unsigned int x86_feature) nit: wrong indentation.