On Fri, 2023-11-17 at 20:26 +0800, Li RongQing wrote: > Static key kvm_has_noapic_vcpu should be reduced when fail > to create vcpu, this patch fixes it > > Signed-off-by: Li RongQing <lirongqing@xxxxxxxxx> > --- > arch/x86/kvm/x86.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 41cce50..2a22e66 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -11957,7 +11957,10 @@ int kvm_arch_vcpu_create(struct kvm_vcpu *vcpu) > kfree(vcpu->arch.mci_ctl2_banks); > free_page((unsigned long)vcpu->arch.pio_data); > fail_free_lapic: > - kvm_free_lapic(vcpu); > + if (!lapic_in_kernel(vcpu)) > + static_branch_dec(&kvm_has_noapic_vcpu); > + else > + kvm_free_lapic(vcpu); > fail_mmu_destroy: > kvm_mmu_destroy(vcpu); > return r; Makes sense. Reviewed-by: Maxim Levitsky <mlevitsk@xxxxxxxxxx> Best regards, Maxim Levitsky
