On Wed, 2023-11-08 at 12:23 +0100, Claudio Imbrenda wrote: > On Tue, 7 Nov 2023 13:31:16 +0100 > Nina Schoetterl-Glausch <nsg@xxxxxxxxxxxxx> wrote: > > [...] > > > diff --git a/arch/s390/kernel/facility.c b/arch/s390/kernel/facility.c > > new file mode 100644 > > index 000000000000..5e80a4f65363 > > --- /dev/null > > +++ b/arch/s390/kernel/facility.c > > @@ -0,0 +1,21 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright IBM Corp. 2023 > > + */ > > + > > +#include <asm/facility.h> > > + > > +unsigned int stfle_size(void) > > +{ > > + static unsigned int size; > > + u64 dummy; > > + unsigned int r; > > reverse Christmas tree please :) Might be an opportunity to clear that up for me. AFAIK reverse christmas tree isn't universally enforced in the kernel. Do we do it in generic s390 code? I know we do for s390 kvm. Personally I don't quite get the rational, but I don't care much either :) Heiko? > with that fixed: > > Reviewed-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx> > > [...]